David Nicholas Williams

Results 16 comments of David Nicholas Williams

No problem, have made the suggested changes but left the versioning as-was as I think a minor then a major bump, respectively for the two PRs, follows semver. Have made...

Good point - I'll roll the versions back in both PRs. Re major and minor version numbers, I was following the definition from here http://semver.org/ I.e. the props thing is...

Again, this branch incorporates the root element props features in my other pull request. I guess it might make sense to merge that one first, then create a 0.x branch...

@thangngoc89 it's because I'm currently requiring the library like this: dependencies: { "markdown-react-js" : "davnicwil/markdown-react-js#1.x" } I.e. pulling from github rather than the npm central repo since my branch isn't...

No worries! Last I heard @alexkuz told me he was reviewing my PRs, as well as considering other changes. Any updates on this @alexkuz? Would be handy to get these...

@kof I haven't looked at this in a long time, and likely won't be able to give it much attention until after the new year, but sure if you want...