dinit icon indicating copy to clipboard operation
dinit copied to clipboard

dinit-log: Add text color

Open TheNofis opened this issue 1 year ago • 2 comments

I just added a couple of lines so that the logging was colored :D

TheNofis avatar May 18 '24 16:05 TheNofis

Thanks for opening a PR. To accept this I would require a few changes: since the color sequences are not universal to every terminal, and since some people wouldn't want them anyway, there should be a (documented) way to turn them off (i.e. a command-line argument). Additionally I would like the escape sequences to named macros or constants rather than embed them directly in the message strings.

davmac314 avatar May 19 '24 01:05 davmac314

Other than cleaning up the PR so that it doesn't include a bunch of built files (as Mobin pointed out):

  • I notice that the same color is used for "FAILED" as "STOPPD" status. I don't think this should be the case. A service that is "stopped" successfully does not indicate an error.
  • the new --color option looks like it is the default anyway so the option has no effect?
  • new option needs documenting in the manual pages

davmac314 avatar Jun 12 '24 13:06 davmac314

Looks like this has gone stale, so I'll close for now; feel free to re-open in future.

davmac314 avatar Aug 23 '24 22:08 davmac314

hey, i'm just bumping this as i love the idea of pretty colors in init and would love to see this be a thing.

paidlowered avatar Jan 30 '25 23:01 paidlowered