David Kean

Results 120 comments of David Kean

Note, if you don't have a `TargetFramework/TargetFrameworks` property inside the project itself as called out in https://github.com/dotnet/project-system/blob/master/docs/opening-with-new-project-system.md, you have to mark it as '9A19103F-16F7-4668-BE54-9A1E7A4F7556'.

This Visual Studio Developer Community issue was root caused to this: https://developercommunity.visualstudio.com/t/visual-studio-is-near-2022-uselessly-slow-for-me/1638239.

@nkolev92 @drewnoakes @zivkan Please reconsider this PR; in dumps taken from a large partner's internal restore, I can see that there are almost half a million of these objects in...

I'm reopening for consideration.

@jeffkl What's blocking this from making progress?

Can you share out a trace? ________________________________ From: Jeff Kluge ***@***.***> Sent: Friday, April 5, 2024 6:55 AM To: NuGet/NuGet.Client ***@***.***> Cc: David Kean ***@***.***>; Review requested ***@***.***> Subject: Re:...

I compared the traces. The highlighted areas where I believe the above change affects. We moved ~45 MB -> 22 MB, but I want to see this is repeatible (I...

I'm not super convinced its testing the exact same thing; I see allocation increases/decreases in the places I expect, but increases in MSBuild code: Why would MSBuild be doing more...

There's a dup of this here: https://github.com/Microsoft/msbuild/issues/2511.