etcdv3-ruby
etcdv3-ruby copied to clipboard
fix: range_end is string
The default value of range_end is defined as an empty string in Etcdv3::Namespace::KV.del. However, nil is assumed in Etcdv3::Namespace::KV::Requests.del_request, creating an inconsistency. Therefore, if range_end is not specified, namespace is assigned to range_end and del will not work correctly.
Looks like we need to move the tests to github actions. In any case, would you mind adding a test to cover this?
Test added. test results on local before fix below,
1) Etcdv3 Insecure connection without Auth namespace #del no range was deleted
Failure/Error: expect(resp.deleted).to eq(1)
expected: 1
got: 0
(compared using ==)
# ./spec/etcdv3_spec.rb:583:in `block (6 levels) in <top (required)>'