jiffy icon indicating copy to clipboard operation
jiffy copied to clipboard

Update used double-conversion?

Open catap opened this issue 1 year ago • 0 comments

Good day,

I had created a port for ejabberd for OpenBSD and during building the port was discovered that ejabberd fails on i386 with error:

===> Compiling /pobj/ejabberd-24.10/ejabberd-24.10/c_src/double-conversion/strtod.cc
===> /pobj/ejabberd-24.10/ejabberd-24.10/c_src/double-conversion/strtod.cc:41:18: error: unused variable 'kMaxExactDoubleIntegerDecimalDigi
ts' [-Werror,-Wunused-const-variable]
static const int kMaxExactDoubleIntegerDecimalDigits = 15;
                 ^
/pobj/ejabberd-24.10/ejabberd-24.10/c_src/double-conversion/strtod.cc:58:21: error: variable 'exact_powers_of_ten' is not needed and will n
ot be emitted [-Werror,-Wunneeded-internal-declaration]
static const double exact_powers_of_ten[] = {
                    ^
/pobj/ejabberd-24.10/ejabberd-24.10/c_src/double-conversion/strtod.cc:84:18: error: unused variable 'kExactPowersOfTenSize' [-Werror,-Wunus
ed-const-variable]
static const int kExactPowersOfTenSize = ARRAY_SIZE(exact_powers_of_ten);
                 ^
3 errors generated.

This error was had come from jiffy's embeded version of double-conversion which was fixed a while ago here: https://github.com/google/double-conversion/pull/123

Here I'm asking: isn't it a good idea to update double-conversion?

catap avatar Nov 28 '24 16:11 catap