safe-regex icon indicating copy to clipboard operation
safe-regex copied to clipboard

added ts definitions

Open Akim95 opened this issue 6 years ago • 8 comments

feel free to contribute and keep it improving!

Akim95 avatar Oct 02 '19 03:10 Akim95

Hi @Akim95, thanks for the contribution.

I haven't used TS before.

Can you clarify for me the maintenance burden this would introduce if I were to modify the API? Is the TS file automatically updated or would new PRs need to update it if they changed the API?

davisjam avatar Oct 06 '19 13:10 davisjam

Hi @Akim95, thanks for the contribution.

I haven't used TS before.

Can you clarify for me the maintenance burden this would introduce if I were to modify the API? Is the TS file automatically updated or would new PRs need to update it if they changed the API?

Need a new PRs but no need to worry if you have any API need to change because people that using this package with Typescript will taking care of it.

Akim95 avatar Oct 07 '19 03:10 Akim95

For the record, I believe most people are using the definitions in DefinitelyTyped for this package.

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/safe-regex/index.d.ts

MarcusOtter avatar Aug 17 '22 02:08 MarcusOtter

Just found this package recently and I'd like to use it with TS definitions. Are there plans to keep this PR up to date and merge it? I can open a new one if the original author isn't available anymore @davisjam

ImRodry avatar Oct 24 '22 21:10 ImRodry

Have there been any changes since the original PR was opened? Maybe it's ready to merge now. Can you please let me know?

Get Outlook for iOShttps://aka.ms/o0ukef


From: Rodry @.> Sent: Monday, October 24, 2022 5:57:12 PM To: davisjam/safe-regex @.> Cc: Davis, James C @.>; Mention @.> Subject: Re: [davisjam/safe-regex] added ts definitions (#29)

---- External Email: Use caution with attachments, links, or sharing data ----

Just found this package recently and I'd like to use it with TS definitions. Are there plans to keep this PR up to date and merge it? I can open a new one if the original author isn't available anymore @davisjamhttps://github.com/davisjam

— Reply to this email directly, view it on GitHubhttps://github.com/davisjam/safe-regex/pull/29#issuecomment-1289668761, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFOD3L6MIRGV5Q23DJKWPMTWE4A3RANCNFSM4I4RFHHA. You are receiving this because you were mentioned.Message ID: @.***>

davisjam avatar Nov 01 '22 13:11 davisjam

It looks like this PR has conflicts and the author hasn't been too active. I'll try to open a new one and make sure that it's up to date!

ImRodry avatar Nov 01 '22 15:11 ImRodry

Thank you

Get Outlook for iOShttps://aka.ms/o0ukef


From: Rodry @.> Sent: Tuesday, November 1, 2022 11:14:03 AM To: davisjam/safe-regex @.> Cc: Davis, James C @.>; Mention @.> Subject: Re: [davisjam/safe-regex] added ts definitions (#29)

---- External Email: Use caution with attachments, links, or sharing data ----

It looks like this PR has conflicts and the author hasn't been too active. I'll try to open a new one and make sure that it's up to date!

— Reply to this email directly, view it on GitHubhttps://github.com/davisjam/safe-regex/pull/29#issuecomment-1298675971, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFOD3L3F7MIKEDGESLN3JCLWGEXTXANCNFSM4I4RFHHA. You are receiving this because you were mentioned.Message ID: @.***>

davisjam avatar Nov 01 '22 15:11 davisjam

Opened the new, up-to-date, PR at #52

ImRodry avatar Nov 01 '22 15:11 ImRodry