daviscook477
The Unlock screen has some visual bugs
Card illustrations should not be "Beta" and relics should not be that small...
The relics issue appears to be because relics are intended to also supply a 256x256 "largeRelics" version of their image.
com.megacrit.cardcrawl.neow.NeowUnlockScreen:open() calls com.megacrit.cardcrawl.relics.AbstractRelic:loadLargeImage() which attempts to fill in the largeImage texture from images/largeRelics/
However, basemod.abstracts.CustomRelic just populates the largeImage with the same texture used for the regular image size.
I've made a patch for this; however, it would technically override anyone who was using CustomRelic but then going in and manually replacing AbstractRelic.largeImg with their own (properly large) Texture.
Note: an alternative fix would be to just leave largeImg null in the CustomRelic constructor. The largeImg field is only actually used in two ways within SlayTheSpire:
- AbstractRelic.render() has logic to render the largeImg if it exists and if you're on the NeowUnlockScreen. Leaving it null would allow the alternate "upscale the default image" logic to fire (similar to my pull request, but way simpler).
- SingleRelicViewPopup.initializeLargeImg() tries to load the same image path, but doesn't actually use the AbstractRelic.largeImg field. This means that leaving it null won't change the current behavior: initializeLargeImg() will still try (and fail) to load a nonexistent image. That's (already) fine, because SingleRelicViewPopup.renderRelicImage() also has "upscale the default image" logic if the largeImg it loaded is null.