serilogger icon indicating copy to clipboard operation
serilogger copied to clipboard

Published 20 hours ago • verified publisher icon davisb10

Feature: FileSink

Open HunteRoi opened this issue 1 year ago • 3 comments

The calls to the filesystem are like the following: image

HunteRoi avatar Jun 13 '24 18:06 HunteRoi

@DrakeXorn Can you add to the PR to update the README with usage examples?

davisb10 avatar Jun 21 '24 19:06 davisb10

Hello @davisb10, we spent some time today with @DrakeXorn to debug an issue with TypeMoq in the tests we wrote. We cannot seem to find the root cause. Could you take a look on your end and maybe indicate us where we might need to triple check?

I have read the entire docs of the package (which is outdated btw) and I can't seem to understand why there's some kind of "goto" when the first this.fileSystem.access is called in the second test. We are supposed to go through the this.fileSystem.stat at some point but it never reaches it nor does it throw an actual exception....

HunteRoi avatar Jun 26 '24 14:06 HunteRoi

I have poked around for a bit as well from your latest commits and do not see any glaring issues. Makes me think it might just be a weird quirk with TypeMoq and the fs/filesystem calls.

What I can do is merge the PR, comment out the fileSink tests, so at least the rest pass, and push as a prerelease like 0.6.0-rc1. Then you can pull it down on your side and try it out for your use-cases. If all works as planned, I can make a 'real' version, and it can just be chalked up to TypeMoq being weird.

Let me know if this will work for you. Thanks!

davisb10 avatar Jun 28 '24 19:06 davisb10