David Glick

Results 452 comments of David Glick

We need to figure out the specifics, but in general this sounds good to me. It should help separate the concern of "how this item is rendered" from the concern...

Wow, that is really confusing. This text comes from https://github.com/plone/plone.base/blob/main/src/plone/base/interfaces/controlpanel.py#L997 In Plone 5 the screenshot you showed from Plone classic is accurate, and that control panel inverts the selected types...

haha, wait, I accidentally was looking at the Plone 6 volto demo site when I took that screenshot

Okay, yeah, Plone 6 classic still has the UI that inverts the selection so that the user is choosing which types ARE searched rather than which types are NOT searched....

@sneridagh I guess we need both: for the short term, add `NODE_OPTIONS=--openssl-legacy-provider` for Node 18 only, and in the long term, we do need to update to a modern webpack...

fwiw, I saw behavior similar to this in a case where I was accidentally using withObjectBrowser to wrap 2 different components. So there were two different SidebarPopup components listening for...

@erral There is already a way to get a valid id that takes into account those checks, which is an INameChooser adapter on the container. The restapi endpoint for adding...

@mauritsvanrees You have a good point that it could be useful to be able to use this endpoint in a mode that throws an error rather than normalizing the id,...

My fix for this was too aggressive, and prevents setting ids that are supposed to be allowed (for example, including capital letters or periods)