flutter_smart_select icon indicating copy to clipboard operation
flutter_smart_select copied to clipboard

Upgrade to null safety

Open sachin052 opened this issue 3 years ago • 11 comments

sachin052 avatar Mar 05 '21 05:03 sachin052

Is there someone working on this? If no one, I would not mind tackling it.

mainawycliffe avatar Mar 07 '21 12:03 mainawycliffe

This is necessary

JErazo7 avatar Mar 08 '21 15:03 JErazo7

Is there someone working on this? If no one, I would not mind tackling it.

Any progress?

simonkimi avatar Mar 19 '21 01:03 simonkimi

I've created PR https://github.com/davigmacode/flutter_smart_select/pull/82 but this is a WIP. If anyone can figure out what's causing the error, I need your help.

iktakahiro avatar Mar 24 '21 01:03 iktakahiro

I've fixed all failure tests!!

If you would like to use it before merging, set the git repository URI to your pubspec.yaml

  smart_select:
    git:
      url: [email protected]:iktakahiro/flutter_smart_select.git
      ref: null-safety

iktakahiro avatar Mar 24 '21 01:03 iktakahiro

I've fixed all failure tests!!

If you would like to use it before merging, set the git repository URI to your pubspec.yaml

  smart_select:
    git:
      url: [email protected]:iktakahiro/flutter_smart_select.git
      ref: null-safety

Could you share to public?

celvinren avatar Mar 24 '21 13:03 celvinren

@celvinren thanks for your mention.

It's a public repository. https://github.com/iktakahiro/flutter_smart_select/tree/null-safety

if Permission denied error occurs when pub get, that may be due to the cache.

Or try the following

  smart_select:
    git:
      url: https://github.com/iktakahiro/flutter_smart_select.git
      ref: null-safety

iktakahiro avatar Mar 24 '21 13:03 iktakahiro

Seems as if there are some breaking changes with the git link. e.g This used to work

SmartSelect<CountryCode>.single(
  value: ...,

but now value isn't defined Among others like state.value and state.valueDisplay not being defined. Is there documentation for what has changed?

alfiepoleon avatar Apr 02 '21 14:04 alfiepoleon

Seems as if there are some breaking changes with the git link. e.g This used to work

SmartSelect<CountryCode>.single(
  value: ...,

but now value isn't defined Among others like state.value and state.valueDisplay not being defined. Is there documentation for what has changed?

value has been replaced with selectedValue I found it in the history of commit.

simonkimi avatar Apr 02 '21 15:04 simonkimi

Seems as if there are some breaking changes with the git link. e.g This used to work

SmartSelect<CountryCode>.single(
  value: ...,

but now value isn't defined Among others like state.value and state.valueDisplay not being defined. Is there documentation for what has changed?

value has been replaced with selectedValue I found it in the history of commit.

Can you please guide me on how to? I have been going through the commit looking for those syntax changes and I have not been successful

alfiepoleon avatar Apr 26 '21 21:04 alfiepoleon

I released https://pub.dev/packages/flutter_awesome_select with fixed null safety. Could you check that everything works for you?

vasilich6107 avatar Nov 12 '21 23:11 vasilich6107

Hi everyone,

I'm really sorry for not maintaining the smart_select package in a long time. It's been a great project, but it's become too difficult for me to maintain, especially since I've been going through a tough time for the past few years.

In its place, I've released a new package called choice. The combination to smart_select and chips_choice with cleaner, more flexible, and composable API for creating inline or prompted choice widgets with single or multiple selection.

I hope you'll check out choice. I think you'll find it to be a great replacement for smart_select.

Thanks for your understanding.

davigmacode avatar Aug 26 '23 10:08 davigmacode