Xrm.Tools.CRMWebAPI icon indicating copy to clipboard operation
Xrm.Tools.CRMWebAPI copied to clipboard

Numerous fixes, fetch all records, added wait and retry using Polly and updated .NET versions

Open mohsinonxrm opened this issue 4 years ago • 4 comments

@davidyack , please review and merge. Fixes: #49 #79 #81 #83 #86

mohsinonxrm avatar Jun 18 '20 21:06 mohsinonxrm

I'm worried about impact of the following to existing users - thoughts? @mohsinonxrm upgraded packages in all projects, targetting .net standard 2.0 only,… … a50110a @mohsinonxrm updated dotnet core project to 3.1, updated standard to netstandard2.0 …

davidyack avatar Jul 08 '20 02:07 davidyack

@davidyack , if we revert the versions, then Polly won't work for resiliency. I've just implemented very basic logic for that. If this gets merged, I plan to enhance it further.

.net core 1.0 reached EOL last year, and the only two versions that are supported are 2.1 and 3.1 on LTS: image

Moving to .net core 3.1 allows us to remove restrictions from the methods that aren't supported, and we can use Polly so that it won't limit the users but give them additional functionality.

Regarding .net standard 2.0, so it gives us more APIs and so allows us to remove restrictions from the methods the same as .net core. However, it does drop .net core 1.0 and 1.1 and some mono and Xamrin versions. image

Here is my opinion; I think we should split the releases. After you're done reviewing and testing this PR and merge it, release it as a v2.0 version and maintain the current branch as v1.x, so that it can be supported for however long, it can be.

That way, work can continue on the v2.0 branch.

Thoughts?

mohsinonxrm avatar Jul 08 '20 18:07 mohsinonxrm

What's the story here? Would love to have Polly support b/c we see 429s a lot...

Sylistron avatar May 04 '21 18:05 Sylistron

@Sylistron , well, I could fork and maintain my own version of it, perhaps?

mohsinonxrm avatar May 07 '21 17:05 mohsinonxrm