David Wengier
David Wengier
A better fix here would be to get the `SuppressAddComponentParameter` flag off of `RazorConfiguration` and put it on `ProjectWorkspaceState`, then I wouldn't have needed to hack things into the `ProjectWorkspaceStateGenerator`...
> it isn't clear to me why `CSharpLanguageVersion` exists on `ProjectWorkspaceState`. Seems like this makes better sense on `RazorConfiguration`? Noting that I am being descriptive, not prescriptive, but in VS...
Okay, pushed up an update to move `UseRoslynTokenizer` and `CSharpLanguageVersion` to `RazorConfiguration`, since they configure the project engine. I would argue `RootNamespace` should move there too, and in fact it...
> ProjectWorkspaceState is probably something that should just go away Agreed. Now it is just tag helpers, and the name makes little sense.
Found an issue in `RemoteDocumentSnapshot` which caused some parts of formatting to run on an older `SourceText` because the project snapshot was old, which means the generator didn't re-run. Have...
This seems to be fixed now, all tests are passing. I think the simplified host outputs did it.
> it looks like we is calling the Razor middleware to remap rename text edits - is there something missing on the razor end? > https://github.com/OmniSharp/omnisharp-vscode/blob/master/src/features/renameProvider.ts#L40
@vzarytovskii is web tools moving to STJ still scheduled for this sprint? Or did I miss it and it's already gone in?
I have local changes that push this branch to latest and seem to work okay in manual testing. The review is not going to be fun though, given this is...
I can only apologise for the size and un-review-ability of this PR, but the integration tests passed, so I've pushed the latest updates. @dotnet/razor-tooling let me know if you would...