David Wengier

Results 345 comments of David Wengier

@costin-zaharia-sonarsource In that example with the namespace, does the mapped span come back with `[HasMappedPath](https://sourceroslyn.io/Microsoft.CodeAnalysis/R/2689bf9173f268a5.html)` equal to `true`? That would be surprising. It's an odd API, but Roslyn will happily...

@martin-strecker-sonarsource Thanks, thats a very informative link. This line in particular: > The #line directive does not specify where the user written expression ends. This surprises me. Logically speaking I...

> the newline at the end of a `@using` statement is no longer part of the using declaration itself Sounds like maybe this fixes https://github.com/dotnet/razor/issues/10375 then?

Personally speaking I've been of the opinion that if the compiler can produce an RZ diagnostic, it shouldn't produce C# code that will also have its own diagnostics. That does...

I was curious so I checked, and currently (lets assume a post-FUSE world so its easier to talk about) given `` the compiler produces the follow. In case you can't...

This would most likrly be a TextMate grammar issue, not compiler.

Roslyn merged there side of this in https://github.com/dotnet/roslyn/pull/73282

Have asked about this on VS Feedback, because I think that this could be a C# compiler thing, where the word "ChatService" could mean either a type or a member,...

There are actually two issues here. 1. What my comment was mainly about, is that `DocumentContextFactory` only works for open documents, so using it in rename, for example, could mean...

> I wouldn't say that EVERY Handler should get the entire solution because that's kind of a big hammer. In Roslyn there is a mechanism for opting out (`RequiresLSPSolution`), and...