David Wendt

Results 84 comments of David Wendt

Who owns the data after this call? I expected that this signature ``` arrow::Status to_arrow_device_arr(std::shared_ptr input, struct ArrowDeviceArray* out, rmm::cuda_stream_view stream) ``` would be more like ``` std::unique_ptr to_arrow_device_array(cudf::table_view const&...

Hey Keith. Thanks but it seems this kind of Arrow-specific logic for an Arrow-specific struct does not belong in libcudf. It seems a bit fragile in that changing how Arrow...

> Is that because you're only passing in a `cudf::table_view` which doesn't own its data, there's no way to guarantee that the data stays alive until the release callback on...

> In theory something like this could be added as a free function in the vendorable header, but you'd need to handle all the nesting structure that columns can have...

Ok, this is what I'm proposing for the 2 `Make` functions to go in the Arrow source. We can name that whatever makes sense. And we can change the return...

I spent some time recoded each of the dispatch functions to use these `Make` factories. Here are few of them for reference. ``` // handles most of the fixed-width types...

Ok. The link was helpful background. > If this lived in the main Arrow library then it eliminates the goal of being dependency free and requires linking libarrow which has...

> > I'd like to consider Arrow providing these functions as an alternative to hand building the struct elements as illustrated in the original proposal. > > I'm not sure...

What version of Arrow includes `ArrowDeviceArray`? I don't see it in the version used by libcudf so upgrading may be a prerequisite for this work. I'm still puzzled by the...

This PR needs to be rebased on branch-24.08.