react-aria-menubutton

react-aria-menubutton copied to clipboard

Bumps [chownr](https://github.com/isaacs/chownr) from 1.0.1 to 1.1.4. Commits 814f642 1.1.4 a0d7ae0 push to github before npm 1a3667a ignore stuff 147eac4 Full tests, handle errors properly in many cases 578fb9f update tap,...

dependabot[bot]

Bumps [tmpl](https://github.com/daaku/nodejs-tmpl) from 1.0.4 to 1.0.5. Commits See full diff in compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: #...

dependabot[bot]

Disabled/hidden button as menu item breaks arrow keys

2

Reduced test case: https://stackblitz.com/edit/react-ts-41mm9f?file=index.tsx 1. Open the menu button 2. Press down arrow key, "foo" is selected 2. Press down arrow key again Actual: "foo" is still selected Expected: "baz"...

OliverJAsh

`MenuItem`: custom `onClick` not fired when `tag` is `button` and user presses enter

2

Reduced test case: https://stackblitz.com/edit/react-ts-sbkech?file=index.tsx If you open the menu, focus the `a`, and then press enter, the custom `onClick` handler is fired as seen from the logs. ✅ If you...

OliverJAsh

Usage with Custom components as MenuItem

4

In the current implementation, the focus management and onClick for the `MenuItem` is internally taken care of . This works alright when the `MenuItem`s are spans which need to trigger...

gaurav5430

Attaching a label to this when used as a select

2

From the demo i can see that this can be used as a select, Select is a form element, which should support label, clicking on which would focus the select...

gaurav5430

In the example usage on the [website](https://davidtheclark.github.io/react-aria-menubutton/demo/) and the [example ](https://github.com/davidtheclark/react-aria-menubutton/blob/master/demo/js/basicDemo.js)as part of the repo, the li which contains the `menuitem` does not have its semantics hidden (using role=presnetation or...

gaurav5430

When using this for creating custom selects, it seems that the selected item is not marked as aria-selected = "true" is that intended? it seems like native selects have that...

gaurav5430

React Router Link inside `MenuButton`

3

I am trying to create a menu whereby each item is a link. The reason I want a link rather than a button: - accessibility, e.g. right click -> open...

OliverJAsh

Fixes this error when passing a (forwarded) `ref` prop into `Button`: ``` Warning: Failed prop type: Invalid prop `forwardedRef` supplied to `AriaMenuButtonButton`. in AriaMenuButtonButton (created by Context.Consumer) ``` 

OliverJAsh