cosmiconfig icon indicating copy to clipboard operation
cosmiconfig copied to clipboard

Types for transformed explorer

Open manferlo81 opened this issue 4 years ago • 1 comments

I am using this package in one of my typescript projects, I noticed an Explorer (or ExplorerSync) search and load methods signature does not change even if you use the transform option, this PR fixes that. I kept the original signature as fallback so no code will be broken. This is not a functionality issue it's a types issue, the methods work as intended, just the types are wrong.

Note that this is a "quick and easy" fix, there are a lot of improvement that can be done "typeswise". I tried to keep all changes contained so it's easy to review.

manferlo81 avatar Apr 08 '20 19:04 manferlo81

Codecov Report

Merging #234 into master will not change coverage by %. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #234   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          227       227           
  Branches        46        46           
=========================================
  Hits           227       227           
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d94bd6c...4c8d481. Read the comment docs.

codecov-io avatar Apr 08 '20 20:04 codecov-io