Dave Bailey

Results 26 comments of Dave Bailey

In case it's helpful, here's how I've hacked MockFirebase in my project to support promises: https://github.com/code-dot-org/code-dot-org/pull/9976/commits/cf4adbc185a91aa726c2e3df3b94a8162204ba5d

any concerns with this documentation update @rafaelfranca ?

> snickell https://github.com/code-dot-org/code-dot-org/pull/54643#issuecomment-1789850667 - This is the one function used outside of apps/storage/firebaseMetadata.js that I wonder if we could easily handle through SQL, it feels like a firebase "subscription".... is...

I agree with what Mark said -- the best practice is to include unit tests in each PR. If you want to defer unit testing, I think it would be...

nice work Ken! LGTM 👍

Thank you for soliciting feedback. I would vote against this one personally. The first post I found on this topic happens to articulate my preferred way of organizing methods within...

> Looks good! I'm pretty slammed this week, so my personal vote would be to hold off on launching this until Monday. 🟢 green light on my end to go...

This appears to be working 👍 1am UTC (6pm yesterday) corresponds to the time of the last DTP: ``` ubuntu@production-daemon:~$ ps -eo pid,lstart,cmd | grep delay 1768893 Thu May 23...

There is some end-to-end test coverage of progress on these types of levels in `bubble_choice.feature`. my recommendation would be to extend those tests to cover a lab2 level to make...

> > There is some end-to-end test coverage of progress on these types of levels in `bubble_choice.feature`. my recommendation would be to extend those tests to cover a lab2 level...