Not working anymore on FF or Chrome. Price always shows "$NaN / night, including fees"

[RayBB]

Title says it

But also thank you so much for making this awesome extension @davidsawyer . It has really been a big help and it's a shame airbnb doesn't do this by default.

Cheers

[davidsawyer]

Thanks for the kind words!

Can you link to a handful of listings where this is happening? I couldn’t reproduce this on my end.

On Feb 22, 2022, at 11:46 AM, Raymond Berger @.***> wrote:

 Title says it

But also thank you so much for making this awesome extension @davidsawyer . It has really been a big help and it's a shame airbnb doesn't do this by default.

Cheers

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.

[RayBB]

Here are a few examples:

• https://www.airbnb.com/rooms/552967095159829179?adults=2&source_impression_id=p3_1645559080_0HY4BLrRhrPMz8OE&guests=1&check_in=2022-06-14&check_out=2022-06-15
• https://www.airbnb.com/rooms/45517179?adults=2&check_in=2022-03-09&check_out=2022-03-10&federated_search_id=bc26f5ce-5a8c-410d-870c-3067110f8d98&source_impression_id=p3_1645571381_kVtDxOCbE%2FOn3Psp

However, it happens for pretty much all the listing. I looked in the dev console and didn't see any errors and I've also tried disabling just about every other extension. One other factor that may be causing it is that I'm on relatively crappy internet so maybe the high ping and slow page loads mean your extension is looking for things on the page before it loads? Maybe throttling your connection to slow3g will reproduce it? https://www.browserstack.com/guide/how-to-perform-network-throttling-in-chrome Let me know if there is anything else I can do to help debug it.

[davidsawyer]

Thanks, I’ll try to take a look soon

On Feb 22, 2022, at 4:15 PM, Raymond Berger @.***> wrote:

 Here are a few examples:

https://www.airbnb.com/rooms/552967095159829179?adults=2&source_impression_id=p3_1645559080_0HY4BLrRhrPMz8OE&guests=1&check_in=2022-06-14&check_out=2022-06-15 https://www.airbnb.com/rooms/45517179?adults=2&check_in=2022-03-09&check_out=2022-03-10&federated_search_id=bc26f5ce-5a8c-410d-870c-3067110f8d98&source_impression_id=p3_1645571381_kVtDxOCbE%2FOn3Psp However, it happens for pretty much all the listing. I looked in the dev console and didn't see any errors and I've also tried disabling just about every other extension. One other factor that may be causing it is that I'm on relatively crappy internet so maybe the high ping and slow page loads mean your extension is looking for things on the page before it loads? Maybe throttling your connection to slow3g will reproduce it? https://www.browserstack.com/guide/how-to-perform-network-throttling-in-chrome Let me know if there is anything else I can do to help debug it.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.

[The1stSword]

I believe this is happening is because AirBnB no longer shows the taxes until you hit the Reserve button. So a solution might be to give a user an option to put in a default tax amount for all searches or remove the taxes in the calculation but that kind of defeats the whole purpose of this extension. Unless there is another way?

[davidsawyer]

Sorry for the delay on this. We just moved to a new house and had twins haha.

But I think I figured this out last night! I’m able to figure out the tax on the listing page. Now I just need to implement it. Stay tuned.

On Mar 1, 2022, at 6:57 PM, Kelly Collard @.***> wrote:

 I believe this is happening is because AirBnB no longer shows the taxes until you hit the Reserve button. So a solution might be to give a user an option to put in a default tax amount for all searches or remove the taxes in the calculation but that kind of defeats the whole purpose of this extension. Unless there is another way?

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.

[RayBB]

Congrats on the move and the twins! Don't worry too much about the tax thing if it puts too much of a tax on a time of big change in your life :)

[davidsawyer]

Thanks! And fixing this will be just the opposite of a tax! This is a good chance for the extension to become even more valuable because it’s doing something a bit less trivial.

On Mar 3, 2022, at 8:08 AM, Raymond Berger @.***> wrote:

Congrats on the move and the twins! Don't worry too much about the tax thing if it puts too much of a tax on a time of big change in your life :)

— Reply to this email directly, view it on GitHub https://github.com/davidsawyer/airbnb-price-per-night-correcter/issues/18#issuecomment-1058136529, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFQY53I4NDKFK7K7BXGSY3U6DIWHANCNFSM5PCG7ZSQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.

[davidsawyer]

Progress! I did all this programmatically. Now I just need to make it more robust.

[jmfulgham]

Hey there, any update on this fix? Thanks again for this resource!

[davidsawyer]

Hey, I'm still working on it! Short on time these days, but I promise it's coming soon! (Barring any unforeseen Airbnb changes, of course 😉)

[Mohamed3on]

hoping you get a fix working soon @davidsawyer :)

[davidsawyer]

Thanks for everyone's patience. Here's a little progress gif for you all!

[davidsawyer]

Alright team, anyone wanna beta test this rough solution? I have some rough corners still in need of smoothing over.

If you're down to test it, download the v1-beta branch, build it, and run it in your browser. The readme instructions should be able to get you there, but let me know if you have issues.

Let me know in this thread how it works and if/when you notice bugs!

Note that I'm planning on adding a more graceful loading indicator of some kind when it re-fetches the tax info in the background when the user changes dates or something that forces a recalculation. Right now, the updating prices may feel a little awkward and/or laggy.

Thanks!

[RayBB]

@davidsawyer just tested v1 beta on firefox and seems to work for some listings but not all.

Appreciate you work fixing this!

Hope this is helpful for debugging :)

Here's the results:

Spoiler

$0 price

https://www.airbnb.com/rooms/46714959?adults=1&children=0&infants=0&check_in=2022-09-14&check_out=2022-09-21&federated_search_id=63abaab7-1f99-43a3-b7b5-14bdc4e63ad4&source_impression_id=p3_1655351916_SBDXMwzzwGuqW5BN

Total price is wrong

https://www.airbnb.com/rooms/26532850?adults=1&children=0&infants=0&check_in=2022-09-04&check_out=2022-09-11&federated_search_id=63abaab7-1f99-43a3-b7b5-14bdc4e63ad4&source_impression_id=p3_1655351917_DbfT07H8OunvxQUZ

https://www.airbnb.com/rooms/23478156?adults=1&children=0&infants=0&check_in=2022-09-04&check_out=2022-09-11&federated_search_id=63abaab7-1f99-43a3-b7b5-14bdc4e63ad4&source_impression_id=p3_1655351917_QYckz3tbDBX5UT88

no price shown at all

https://www.airbnb.com/rooms/4869137?adults=1&category_tag=Tag%3A675&children=0&infants=0&search_mode=flex_destinations_search&check_in=2022-12-25&check_out=2022-12-30&federated_search_id=31de57a9-4feb-41b7-9584-5b8e2c1533fd&source_impression_id=p3_1655351828_%2B4SrNtF58CIscZqa

https://www.airbnb.com/rooms/46604828?adults=1&category_tag=Tag%3A675&children=0&infants=0&search_mode=flex_destinations_search&check_in=2022-06-20&check_out=2022-06-25&federated_search_id=31de57a9-4feb-41b7-9584-5b8e2c1533fd&source_impression_id=p3_1655351829_6g75R09oojtS2d2m

[davidsawyer]

Incredibly valuable bug reports. I'll dig into these soon!