clojure-csv icon indicating copy to clipboard operation
clojure-csv copied to clipboard

Added support for CR as line-end char

Open kriyative opened this issue 9 years ago • 3 comments

kriyative avatar Oct 14 '15 04:10 kriyative

What is this for? The end-of-line is already configurable with the :end-of-line argument in both reading and writing.

davidsantiago avatar Oct 14 '15 04:10 davidsantiago

  1. CR is the line-end convention used by Excel on OSX for CSV exports, so it seems to be quite common in the wild
  2. end-of-line does allow passing in CR, but that requires the caller to know a-priori the convention used in the file being read
  3. Adding a layer around clojure-csv to pre-test the line-end seems excessive, especially when clojure-csv is doing that anyway

Perhaps, I've missed something about the intended use of end-of-line ... would be happy to understand.

Cheers.

kriyative avatar Oct 14 '15 13:10 kriyative

That is exactly what I was about to code. Well, any chance it gets merged so we do not have to fork it ourself.

Boubalou avatar Feb 23 '18 18:02 Boubalou