tsurukame icon indicating copy to clipboard operation
tsurukame copied to clipboard

Font Size

Open sagecedar opened this issue 4 years ago • 13 comments

I’ve been using your app for quite a while and loved it. I increased the font size to largest size but didn’t see any change. I’m low vision so font size is important to me. Anyway, just this morning, it was like, WHOA! It’s giant! But, the rest is still not correct. I mean, if I made a typo, the info it displayed - the definition and kana are still too small (or remain unchanged.) ![Uploading 5C99884E-A9E1-4723-92CE-79C93D50EF62.png…] 352265BD-14FA-4829-8BF2-8F4762A9C899. I use iPad Pro, by the way.

sagecedar avatar Mar 29 '20 17:03 sagecedar

Just wanted to clarify that while font size works great for the main kanji. What I would like to see is ability to change fonts for the rest, such as the meaning and kana, etc. Does that make sense?

Thanks,

Jeremy

Sent from my iPad

On Mar 29, 2020, at 4:55 PM, turtlemaster19 [email protected] wrote:

 @sagecedar Yep, that's the font size. We can tell it's an iPad Pro, but I agree the font size setting could be better done. Leaving this open to comments from others...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

sagecedar avatar Mar 31 '20 00:03 sagecedar

@sagecedar Definitely, that's why I don't want it to close, since that screenshot looks awful on the iPad with that font size.

This is due to the implementation in #294

UInt2048 avatar Mar 31 '20 00:03 UInt2048

Totally agree. On an iPad pro's large screen, the text is illegibly small at times. I can read the English, but cannot make out the complex Kanji, especially with the low contrast red on dark grey motif.

For size comparison, look at the clock and "< Back" button in the upper left. These are the smallest fonts generally used on iPad – and only in this simple case for controls which should not get your attention.

The main font for this app is smaller than the "< Back" button. For iPad pro, roughly double would be considered normal.

E70CC7EB-8D58-4E8A-88EA-D50D29303EE3

For comparison... 359C8572-0D5F-4C54-9516-87B9AAF807D3

jeff8v7 avatar Apr 12 '20 23:04 jeff8v7

By the way... another font size slider probably isn't needed, as most apps don't have one. Just make the default text size relative to the screen size...

PS: I know the blurred out text is intentionally illegible in the first screen shot. I wasn't referring to that :-)

jeff8v7 avatar Apr 12 '20 23:04 jeff8v7

@sagecedar I noticed that the text is seems more legible with the "light" theme. This might be a quick improvement for you :-)

B7FAFC5D-4A9C-4928-B0CF-63E503F58217

jeff8v7 avatar Apr 13 '20 00:04 jeff8v7

@jeff8v7 I don't think that makes much of a difference. :P

UInt2048 avatar Apr 19 '20 00:04 UInt2048

Really? My eyes must be pretty bad..

jeff8v7 avatar Apr 19 '20 02:04 jeff8v7

@jeff8v7 I finally saw what you meant when I tried it on my phone without glasses today. I couldn't say it was super noticeable on the iPad, because the screen size was so large, that the effect was diminished. (Maybe that's just because I am nearsighted...)

Those are some good points you made, and I hope that we can fix this soon...

UInt2048 avatar Apr 25 '20 15:04 UInt2048

Bumping this up - I use Tsurukame on an iPad mini and the text is tiny. I made the text size bigger in the iPad settings but Tsurukame doesn't seem to respect this as it has no effect (I've noticed it changes the text size in some but not all apps). I don't really care whether Tsurukame respects the iOS text settings or has its own setting but would be really great to support larger text throughout the app.

aaron-meyers avatar Apr 12 '21 17:04 aaron-meyers

The font size setting seems to apply to the item being tested only. On a large iPad, the item is actually uncomfortably large, while all other text is uncomfortable small.

On Apr 13, 2021, at 2:53 AM, Aaron Meyers @.***> wrote:

 Bumping this up - I use Tsurukame on an iPad mini and the text is tiny. I made the text size bigger in the iPad settings but Tsurukame doesn't seem to respect this as it has no effect (I've noticed it changes the text size in some but not all apps). I don't really care whether Tsurukame respects the iOS text settings or has its own setting but would be really great to support larger text throughout the app.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

jeff8v7 avatar Apr 14 '21 01:04 jeff8v7

Is it possible to utilize Dynamic Font features? So that any text can be dynamically scaled using built-in a11y features of the iOS? I found some related article: https://mobilea11y.com/guides/swiftui/swiftui-dynamic-type/ I could give it a try with the support from the authors (because I have no experience in iOS development, only web-dev).

geerk avatar Jan 15 '22 04:01 geerk

@geerk We do some of that already.

UInt2048 avatar Jan 15 '22 15:01 UInt2048

@UInt2048 I mean in the screenshot from the issue description some labels use dynamic font so they have larger font (probably because they do not have font size specified here), but the text content actually stays unchanged probably because the font size is hard-coded here.

geerk avatar Jan 16 '22 02:01 geerk