axum-live-view icon indicating copy to clipboard operation
axum-live-view copied to clipboard

Fix html node literal attributes not being quoted properly

Open Zagitta opened this issue 2 years ago • 2 comments
trafficstars

This fixes an issue where something like html!{ <div class="abc def"></div> } would result in this html: <div class=abc def></div> because LitStr eats the quotes during parsing. This simply adds them back during node_to_tokens.

Zagitta avatar Mar 02 '23 13:03 Zagitta

I've fixed the CI error in https://github.com/davidpdrsn/axum-live-view/pull/160 so if you rebase main it should pass.

davidpdrsn avatar Mar 02 '23 18:03 davidpdrsn

I've fixed the tests which I feel adequately cover this change. Fixing this the proper way and putting quotes around all evaluated output is a huge hassle and I'm not getting nerd sniped into doing that.... for now... 😛

Zagitta avatar Mar 03 '23 22:03 Zagitta