node-highcharts icon indicating copy to clipboard operation
node-highcharts copied to clipboard

Doesn't work with latest jsdom

Open xrkolovos opened this issue 9 years ago • 5 comments

TypeError: jsdom.jsdom(...).createWindow is not a function at createHighchartsWindow

xrkolovos avatar Jan 15 '16 16:01 xrkolovos

I'm amazed it gets that far. It hasn't run against JSDom versions for years.

I was hoping they'd recommend a better solution by now but it looks like they're still linking to me.

Would the PhantomJS approach work for you?

davidpadbury avatar Jan 20 '16 17:01 davidpadbury

Try changing: var window = jsdom.jsdom().createWindow(),
to var window = jsdom.jsdom().defaultView,
in ./lib/node-highcharts.js

guidov avatar Apr 04 '16 03:04 guidov

with var window = jsdom.jsdom().defaultView, it is generating 1kb chart.png, no error, but not working.

Any advise?

munavargit avatar Dec 07 '16 07:12 munavargit

it's been several years since I've actively used these techniques. Any errors from jsdom visible?

davidpadbury avatar Dec 07 '16 13:12 davidpadbury

Thanks for the response.

With var window = jsdom.jsdom().createWindow(), below error reported.

TypeError: jsdom.jsdom(...).createWindow is not a function at createHighchartsWindow (D:\Source-Code\nodeJs-chart-serverside\node_modules\node-highcharts\lib\node-highcharts.js:5:30) at Object.render (D:\Source-Code\nodeJs-chart-serverside\node_modules\node-highcharts\lib\node-highcharts.js:46:2) at D:\Source-Code\nodeJs-chart-serverside\app.js:55:12 at Layer.handle [as handle_request] (D:\Source-Code\nodeJs-chart-serverside\node_modules\express\lib\router\layer.js:95:5) at next (D:\Source-Code\nodeJs-chart-serverside\node_modules\express\lib\router\route.js:131:13) at Route.dispatch (D:\Source-Code\nodeJs-chart-serverside\node_modules\express\lib\router\route.js:112:3) at Layer.handle [as handle_request] (D:\Source-Code\nodeJs-chart-serverside\node_modules\express\lib\router\layer.js:95:5) at D:\Source-Code\nodeJs-chart-serverside\node_modules\express\lib\router\index.js:277:22 at Function.process_params (D:\Source-Code\nodeJs-chart-serverside\node_modules\express\lib\router\index.js:330:12) at next (D:\Source-Code\nodeJs-chart-serverside\node_modules\express\lib\router\index.js:271:10) at jsonParser (D:\Source-Code\nodeJs-chart-serverside\node_modules\body-parser\lib\types\json.js:103:7) at Layer.handle [as handle_request] (D:\Source-Code\nodeJs-chart-serverside\node_modules\express\lib\router\layer.js:95:5) at trim_prefix (D:\Source-Code\nodeJs-chart-serverside\node_modules\express\lib\router\index.js:312:13) at D:\Source-Code\nodeJs-chart-serverside\node_modules\express\lib\router\index.js:280:7 at Function.process_params (D:\Source-Code\nodeJs-chart-serverside\node_modules\express\lib\router\index.js:330:12) at next (D:\Source-Code\nodeJs-chart-serverside\node_modules\express\lib\router\index.js:271:10)

var window = jsdom.jsdom().defaultView, it generating 1kb chart.jpg, which is invalid format. And, the service is keep executing. Please let me know, if you need any more detail.

munavargit avatar Dec 08 '16 02:12 munavargit