react-native-youtube icon indicating copy to clipboard operation
react-native-youtube copied to clipboard

V1.1.1

Open chichilatte opened this issue 4 years ago • 1 comments

Hi I'm working on a React Native 0.59 project using react-native-youtube v1.1.0 and wanted to backport a couple of commits from newer versions. Specifically...

  • Update build.gradle: https://github.com/davidohayon669/react-native-youtube/commit/408e12e39d9ee99ffd225eb54a2cbd831d8b88b0
  • Refactor layout resizing hack for Android native module: https://github.com/davidohayon669/react-native-youtube/commit/c9a0c38c1799f7cfb7d3ad9435ad834c52ba56d8

I branched from commit 1c2d9d (that seemed to be the last of the v1 commits) and made the changes. Seems to be working very well! 🍾 🍸

I gave mine a new version in the package.json (v1.1.1), sitting on branch v1.1.1 of my fork. Hoping it's simple to merge into a new branch in your repo, and that someone might find it as useful as we have.

Many thanks for your great work!

Chichi

chichilatte avatar Jun 23 '20 00:06 chichilatte

Sorry, this doesn't work. Causes unpredictable pausing during playback.

darriuk avatar Jul 02 '20 10:07 darriuk