react-native-youtube icon indicating copy to clipboard operation
react-native-youtube copied to clipboard
verified publisher icon davidohayon669

Change type of variables related to time to float

Open ghsdh3409 opened this issue 7 years ago • 2 comments

Summary

  • It closes #280.
  • Before this change, seekTo and currentTime worked with integer second.
  • It supports FLOAT SECONDS in the seekTo and currentTime.
  • I checked that seekTo and currentTime works on both iOS and Android.

Test/Review Plan

  • Code Review
  • Please test it works on the SAMPLE PROJECT.

Comment

  • Sorry for unclean commits. Please merge this by SQUASH MERGE.

ghsdh3409 avatar Mar 31 '18 07:03 ghsdh3409

@ohtangza

ghsdh3409 avatar Mar 31 '18 07:03 ghsdh3409

@ohtangza @ghsdh3409 hey guys, any chance we could get this merged?

webdevbyjoss avatar Jan 08 '19 16:01 webdevbyjoss