gerrit-oauth-provider icon indicating copy to clipboard operation
gerrit-oauth-provider copied to clipboard

domain support for Github oauth

Open susu3621 opened this issue 8 years ago • 4 comments

I mentioned on config's doc, only Google Oauth support domain feature. https://github.com/davido/gerrit-oauth-provider/blob/master/src/main/resources/Documentation/config.md

Is there any plan to have domain support the Github Oauth? It would be great if the "domain" feature is general for all oauth service.

Thanks!

susu3621 avatar Jan 21 '17 17:01 susu3621

Does GitHub provider support that feature?

davido avatar Jan 21 '17 20:01 davido

I think this doesn't need github provider support. If the plugin is considered as a oauth proxy, we can have this feature, just like what https://github.com/bitly/oauth2_proxy is doing.

susu3621 avatar Jan 26 '17 11:01 susu3621

/CC @lucamilanesio

davido avatar Jan 26 '17 12:01 davido

I'm interested in such future too, or at least some auth logging so i can check user email domains with logstash or something else.

fstefanov avatar Jun 05 '17 23:06 fstefanov