vite-plugin-node-polyfills icon indicating copy to clipboard operation
vite-plugin-node-polyfills copied to clipboard

Bug: 0.23.0 broken for vite & pnpm

Open Azq2 opened this issue 11 months ago • 4 comments

Summary

0.17.0 - works fine 0.23.0 - broken:

$ pnpm run build

> [email protected] build /home/azq2/dev/sie/js/web-tools
> vite build

vite v5.4.14 building for production...
✓ 530 modules transformed.
x Build failed in 2.85s
error during build:
[vite:worker] [vite]: Rollup failed to resolve import "vite-plugin-node-polyfills/shims/buffer" from "/home/azq2/dev/sie/js/node-sie-serial/dist/src/AtChannel.js".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`
file: /home/azq2/dev/sie/js/web-tools/src/workers/SerialWorker.js?worker
    at viteWarn (file:///home/azq2/dev/sie/js/web-tools/node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/vite/dist/node/chunks/dep-CHZK6zbr.js:65747:17)
    at file:///home/azq2/dev/sie/js/web-tools/node_modules/.pnpm/[email protected][email protected][email protected]_@[email protected][email protected]_/node_modules/vite-plugin-node-polyfills/dist/index.js:71:17
    at handleCircularDependancyWarning (/home/azq2/dev/sie/js/web-tools/node_modules/.pnpm/[email protected]/node_modules/node-stdlib-browser/helpers/rollup/plugin.js:29:3)
    at onwarn (file:///home/azq2/dev/sie/js/web-tools/node_modules/.pnpm/[email protected][email protected][email protected]_@[email protected][email protected]_/node_modules/vite-plugin-node-polyfills/dist/index.js:68:15)
    at onRollupWarning (file:///home/azq2/dev/sie/js/web-tools/node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/vite/dist/node/chunks/dep-CHZK6zbr.js:65777:5)
    at onwarn (file:///home/azq2/dev/sie/js/web-tools/node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/vite/dist/node/chunks/dep-CHZK6zbr.js:47623:7)
    at file:///home/azq2/dev/sie/js/web-tools/node_modules/.pnpm/[email protected]/node_modules/rollup/dist/es/shared/node-entry.js:20557:13
    at Object.logger [as onLog] (file:///home/azq2/dev/sie/js/web-tools/node_modules/.pnpm/[email protected]/node_modules/rollup/dist/es/shared/node-entry.js:22286:9)
    at ModuleLoader.handleInvalidResolvedId (file:///home/azq2/dev/sie/js/web-tools/node_modules/.pnpm/[email protected]/node_modules/rollup/dist/es/shared/node-entry.js:21169:26)
    at file:///home/azq2/dev/sie/js/web-tools/node_modules/.pnpm/[email protected]/node_modules/rollup/dist/es/shared/node-entry.js:21127:26
 ELIFECYCLE  Command failed with exit code 1.

Azq2 avatar Mar 14 '25 09:03 Azq2

@Azq2 can you please provide a StackBlitz reproduction for this problem?

davidmyersdev avatar Mar 23 '25 21:03 davidmyersdev

same with yarn

SPAHI4 avatar Mar 26 '25 08:03 SPAHI4

@Azq2 and @SPAHI4: There are a few workaround you can try here: https://github.com/davidmyersdev/vite-plugin-node-polyfills/issues/81

Tobbe avatar Mar 29 '25 12:03 Tobbe

Confirming this is a duplicate of #81 - on node 22 and node 24.

Downchuck avatar Jun 01 '25 18:06 Downchuck