Reuse same client port numbers for all connections

[georgeharker]

Disambiguation is done via ssrc. This allows connecting to multiple exported connections on the mioxl.

There’s some other stuff in here like addicting midi clock message support and control of the service name.

Likely the approach of multiple clients n-1 of which refuse mismatching ssrc is sub optimal.

[davidmoreno]

Hey, thanks a lot for the pull request.

Its a lot of changes, and I'm not sure all them must be applied. I will try to go though it these days.

For the moment I will add some comments, to ask specific questions about the reasoning of some changes, if you dont mind.

[georgeharker]

Please do. I don’t think it’s what I’d traditionally submit as a pr. Still trying to figure out how to export a wire shark that doesn’t dump all my traffic. As I said before I think what I did is a bit of a hack and ideally there would be a table to translate remote ssrc to the correct connection for handling rather than what I did.

I’m still pretty convinced the protocol is supposed to be single pair of ports connecting to many serviced muxed on ssrc. But my changes are definitely a kludge to do that.

If I have time I’ll try and suggest something less kludgy. I’m a bit tied up trying to complete the core code base I’m aiming for which is separate to rtpmidi.

George

On Sun, May 9, 2021 at 2:33 AM David Moreno Montero < @.***> wrote:

Hey, thanks a lot for the pull request.

Its a lot of changes, and I'm not sure all them must be applied. I will try to go though it these days.

For the moment I will add some comments, to ask specific questions about the reasoning of some changes, if you dont mind.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/davidmoreno/rtpmidid/pull/40#issuecomment-835764266, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQRYIFQCIJ243FZ5VKNP3DTMZJE3ANCNFSM4373BB7A .

[KoenVda88]

Hi,

If I may jump in, adding the real time events works great, it's definitely something I need. So adding it to the master could be helpful.

Thanks!

[davidmoreno]

Hi,

If I may jump in, adding the real time events works great, it's definitely something I need. So adding it to the master could be helpful.

Thanks!

I just added this specific part to master.

Other are already in, or being worked another branch.

[davidmoreno]

Code would not apply on current master.

Please open a issue or another pull request.

Thanks a lot anyway for the effort for creating this pull request.