number-keyboard
number-keyboard copied to clipboard
davidmigloz
Added "keyboard" mode and four column option (with minus & enter)
For my finance app I needed a keyboard that could enter signed decimal numbers but act like the system keyboard since I had multiple edit texts in a list and didn't want to have fixed numpad views in there.
I liked your library so I extended it with a new keyboard type, the 4 column (I needed the room for the sign change). I have attached a screenshot for you. It uses it's own layout file and all existing modes work without change.
I also needed a way to show the numpad instead of the keyboard. I opted for opening the IME first and then overlaying it with the numpad. The downside is that the first time that the IME opens it is visible for a split second (we need it to open to get it's height). The upsides are that the back button becomes the "down button" as with a real IME, and that the height of the numpad is correct. The code for the popup is loosely based on https://github.com/vanniktech/Emoji (will push some more attribution into the source with the next commit).
I've added a new sample Activity to showcase the new stuff.
Hi Kevin, thank you very much for the PR 😃 I'll review it in the next couple of days. Cheers!
Hi David, you're very welcome, thanks for the nice project :) I pushed a small fix.
I'm having a pretty busy week... but I haven't forgotten your PRs :) Sorry for the delay and thank you!
No worries :) I had to merge the branch for the second PR into master because there was so much overlap between both, so I’m afraid currently it’s an all-or-nothing situation. If you want to have the popup without the 4 column mode I’ll look into cherry-picking or separating the code manually.
On 23. Aug 2018, at 23:37, David Miguel Lozano [email protected] wrote:
I'm having a pretty busy week... but I haven't forgotten your PRs :) Sorry for the delay!
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/davidmigloz/number-keyboard/pull/16#issuecomment-415579242, or mute the thread https://github.com/notifications/unsubscribe-auth/ABygX0ewb3Q8ZlOWbxHk00dOz86NMmt3ks5uTyCYgaJpZM4V-UL4.
Thanks for this, I need the 4 column view for my app, any chance this could be merged or at least conflicts resolved?
This PR never made it to main unfortunately (my bad). The library has now been migrated to compose, so I'll close it.