drag-to-close icon indicating copy to clipboard operation
drag-to-close copied to clipboard

Published 20 hours ago • verified publisher icon davidmigloz

New features

Open sk3llo opened this issue 6 years ago • 4 comments

Hey! I like your library and I added some functionality to it:

  • "dragDirection" attr (Up/Down/UpAndDown swipes)
  • "finishFragmentByTag" attr (String)
  • "finishFragmentByContainerId" (reference container layout of fragment) and some minor bug fixes. But I've done that in kotlin. If you want I can share a code - I dunno how to do pull requests =\

sk3llo avatar Oct 24 '18 14:10 sk3llo

Hi sk3llo!

That's awesome 😃 If you don't want to make a PR share the code with me and I'll include it.

I was thinking to migrate the library to Kotlin when a have some spare time, so it'll be a good moment to include your changes.

Thank you!

davidmigloz avatar Oct 24 '18 14:10 davidmigloz

Sorry for slow reply - kinda busy day. I made a simple app to show what I've done. Please check it out and tell me what you think. It's my first contribution hooray lol

sk3llo avatar Oct 24 '18 22:10 sk3llo

Thank you very much @sk3llo!
I'll integrate your changes when I work in the Kotlin migration 😄

davidmigloz avatar Nov 05 '18 06:11 davidmigloz

Sounds good 😊

sk3llo avatar Nov 20 '18 10:11 sk3llo