Dave Foley

Results 30 comments of Dave Foley

Thanks for the report. Currently there is no way to set `tabIndex` on a `ModalLink`, or to set aria props. As a workaround, you can use a `ModalRoute` and a...

Hmmm.. can you share a snippet with your routing setup? Thanks.

I believe I fixed this back in March (v1.3.3) with the addition of `autoRestoreScrollPosition` on `ModalContainer`. (I forgot that this issue existed).

Are you wanting to detect when the *first* modal is opened and when the *last* one is closed? For that, it might make sense to add `onFirstModalOpen` and `onLastModalClose` props...

Not quite the original request, but note that I added `onFirstModalMounted` and `onLastModalUnmounted` handlers to ModalContainer in v1.3.3.

Thanks for the report. Do you experience the same behavior on other small screens?

Thanks for the info. I'll try to take a look this weekend. Is your project in a public place where I can try it out? Thanks.

Good catch -- this is an error in the documentation. I'll fix it. In the meantime, the correct prop is `bodyModalOpenClassName`. Thanks for the report!

Also should add handling of a/an. Will also need to support genders (le/la for FR, etc.)

... or I need to beef up the runner, integrate with VS, add a nice MSBuild task and end the test-generation nonsense.