Dave Foley

Results 30 comments of Dave Foley

I think I found and fixed this bug in version 1.5.1. Please let me know if you get a chance to test it.

This is kind of a difficult one due to the portal lifecycle in react. I hacked around the problem by copying the content (`innerHTML`) that is rendered in the modal...

Have you tried using `path='*/login'` for the login ModalRoute?

I think I understand now -- when the user clicks a Link to '/login' from '/foo' you want the window.location to be '/login' and to show a login modal on...

@cjmoran I think it might be easiest to handle your backdrop outside of react-router-modal: - Have a ModalRoute that matches `/tweet/:tweetId` - Have a separate route that matches `/` (or...

Good feature request. In the meantime, there is an undocumented workaround: you can provide a function for `parentPath` and it will be invoked with the current `Match` and the result...

The stacking order is controlled by: 1. For `` components, one can specify `stackOrder` -- see: https://github.com/davidmfoley/react-router-modal#modal. If not specified, the modals will be stacked in the order that they...

Can you provide a little bit more information about what you are trying to do? You can add `` elements inside a `

This is a great idea. I'm a TypeScript novice but I think the types should be pretty similar to the flow types that are already there, e.g. https://github.com/davidmfoley/react-router-modal/blob/master/src/modal_container.js#L17