randomColor icon indicating copy to clipboard operation
randomColor copied to clipboard

Published 20 hours ago • verified publisher icon davidmerfield

Rewrote the HexToHSB function. This fixes #141

Open naveloranges opened this issue 3 years ago • 4 comments

The bug was originated from the current HexToHSB function returning undefined when passed particular hex values as argument.

naveloranges avatar Jul 07 '21 15:07 naveloranges

Thanks for this. I will merge if you remove the linting/white-space changes, and the changes to .gitignore.

(Otherwise, I'm more than happy to change the HexToHSB function myself if needed)

Sincerely, David

davidmerfield avatar Jul 08 '21 15:07 davidmerfield

Thanks for the feedback. I did it. Now it's ready to be merged.

naveloranges avatar Jul 08 '21 18:07 naveloranges

Thanks for making those changes – now I'm worried that unfortunately that function doesn't do what is says it does. HSB seems to be different to HSL and the function you include seems to deal with HSL rather than HSB.

I will look into this further

davidmerfield avatar Jul 22 '21 21:07 davidmerfield

Okay. Glad if that helped.

naveloranges avatar Jul 23 '21 15:07 naveloranges