davidmckenzie
davidmckenzie
Nice one, looks like this includes the changes from #339 as well though. Feel free to submit with only the modal changes, as I suspect we'll need to rework #339...
@s3m1s0n1c it should only display on mobile view when columns are truncated, where it would be useful. May consider moving it to an unobtrusive button pinned to the right instead...
oooh accordian is nice, good idea, kinda like what I started on with #167 / #171 but never got around to finishing
You could do some hackery on lines 513 and 515 of server/routes/api.js - just drop the `AND address` chunk and it'll filter on the message content only. Only problem is...
> And just to have it said: I don't expect you to build all this, it's just what I think would be really cool and maybe some things find their...
> side note, why does this cron exist for mysql only? something i'm missing? It was a workaround for the poor alias refresh time that only seems to become a...
> I still don't understand github. PR's are fairly new to me. I feel like it wants me to click something somewhere.. it's just waiting on marshy's review then we...
fwiw, here's a thread re validation on the particular module we use: https://github.com/kelektiv/node-cron/issues/419
I like it, all makes sense. `afterTransport` could be an interesting one if the `transport` plugins were storing response states, since it could trigger an alternative notification if something fails
These are awesome suggestions, thanks! I sadly haven't had much time for this project lately, work commitments getting in the way. More than happy to review any PRs if anyone...