David Martos

Results 113 comments of David Martos
trafficstars

@jonasfj I managed to simplify the PR code. Now the router entry and param parsing code is untouched. What I believe is not possible to do with `Router.all` + `Request.change`...

@jonasfj Ok I see what you mean now, thanks for the snippet! Yes, I can see how creating a subrouter every time a request is handled would be very wasteful....

@jonasfj Thanks for the ideas! Unfortunately all of those depend on `mount` supporting parameters, which it doesn't at the moment. This throws an internal error in `shelf` because the URL...

@jonasfj I've modified the PR in [1a7d4dc](https://github.com/dart-lang/shelf/pull/288/commits/1a7d4dcdc7a8156b3275543cca664b002930148d) so that Routers are not created inside the handlers. For that to work, the parameters extracted from the `mount` prefix need to be...

> What would be the alternative? It would be nice imo to have both the mount handler as well as nested route handlers (from sub-routers) receive the params. Yes, having...

@jonasfj Is there anything else that you see it could be improved in the PR in order to get merged? Unfortunately at the moment is not possible to build additional...

The problem is that `maxLengthEnforced` has been deprecated for a while and now it has been removed from the Flutter framework. I've opened a PR that fixes the deprecation in...

@0xC316c you can update the package to version 4.0.0

I started to notice this as well when loading some cached images. I am not able to reproduce it constantly, but my app has like 10 cached images in the...

I would love to see this feature implemented. I'm currently using a fork which adds an optional parameter "personalizedAds" to comply with the GDPR.