fast-redact icon indicating copy to clipboard operation
fast-redact copied to clipboard

Support multiple wildcards

Open JohnLKramer opened this issue 4 years ago • 6 comments

Because only one wildcard per path is supported, there is no way to redact anything inside a doubly nested array.

E.g. in the following object, you can redact anything underneath tokens unless you redact everything underneath tokens:

{ creditcards: [ { amount: 0, tokens: [ { tokenValue: 'string', tokenType: 'string', cardType: 'string', expDate: 'string', cardHolderName: 'string', lastFour: 'string', }, ], }, ], }

Unless I am missing something. Would be great to support.

JohnLKramer avatar Aug 17 '20 22:08 JohnLKramer

Would you like to send a Pull Request to address this issue? Remember to add unit tests.

mcollina avatar Aug 18 '20 04:08 mcollina

I hope to have time to work on it.

JohnLKramer avatar Aug 18 '20 14:08 JohnLKramer

I created a branch and have been working on this. It's mostly done but it needs some additional tests and I have not been able to check the groupRestore. Unfortunately, I cannot create the branch on origin. I can send over a patch or if you can grant me permissions I can create the branch on origin and push the changes that way. Let me know. Thank you.

champagnetony avatar Apr 30 '21 19:04 champagnetony

fast-redact-issue-27-patch.txt

Feel free to change it up, rework it etc. Let me know if you have any questions. Thank you!

champagnetony avatar May 03 '21 13:05 champagnetony

Please open a PR on github, you need to create your own fork.

mcollina avatar May 03 '21 14:05 mcollina

Any progress here? :)

arealmaas avatar Jul 07 '22 12:07 arealmaas