gcc-python-plugin icon indicating copy to clipboard operation
gcc-python-plugin copied to clipboard

False positive with PyArg_UnpackTuple seen analyzing postgresql

Open davidmalcolm opened this issue 8 years ago • 2 comments

http://fedorapeople.org/~dmalcolm/gcc-python-plugin/2012-02-18/postgresql-9.1.2-2.fc17/postgresql-9.1.2/src/pl/plpython/plpython.c.PLy_output-refcount-errors.html#report-1

davidmalcolm avatar Feb 09 '17 20:02 davidmalcolm

Imported from trac issue 33. Created by dmalcolm on 2012-02-18T11:09:07, last modified: 2012-05-07T13:45:18

davidmalcolm avatar Feb 09 '17 20:02 davidmalcolm

Trac comment by dmalcolm on 2012-05-07 13:45:18:

The false positive here is that the checker is considering the case {{{ when PyArg_UnpackTuple() fails }}} whereas that's not possible: the code already checked: {{{ if (PyTuple_Size(args) == 1) }}} above, so with that guard, PyArg_UnpackTuple can't fail.

davidmalcolm avatar Feb 09 '17 20:02 davidmalcolm