vscode-languagetool-linter icon indicating copy to clipboard operation
vscode-languagetool-linter copied to clipboard

Manage Ignored Rules Internally

Open davidlday opened this issue 5 years ago • 5 comments
trafficstars

Managed ignored rules similar to how ignored words are managed. Consider adding an option to either pass the rules to LanguageTool, or simply have rules ignored on the client side.

davidlday avatar Dec 08 '19 20:12 davidlday

Would it be a step forward to allow regular expression in ignored word ?

ghost avatar Jun 23 '20 08:06 ghost

@St-Ex-savadenn - I'm open to the idea, but I'm not sure I understand the suggestion. Can you describe a little more how this would work?

davidlday avatar Jun 23 '20 19:06 davidlday

In the settings Ignored Words Global support both simple word and regular expression. If a word match either a word or a regex, it's ignored from the linter.

In the following exemple, the second entry would prevent several word to be detect as error : Github, Gitlab, Gitfoobarb, etc image

I'll try a PR with this idea if you want

See https://github.com/davidlday/vscode-languagetool-linter/issues/150

ghost avatar Jun 23 '20 21:06 ghost

I just read manager.ts and it might be better to have a list of regular expression on its own. To prevent calling a regex match on a very long list of word.

See https://github.com/davidlday/vscode-languagetool-linter/issues/150

ghost avatar Jun 23 '20 21:06 ghost

@St-Ex-savadenn - I think I get it now.

This issue is about adding a feature to ignore LanguageTool Rules, like SENTENCE_WHITESPACE.

I think you're suggesting using regex as rules for ignoring groups of words during spell check. If that's the case, would you please open a new feature request Issue? Very interesting idea. Had not even crossed my mind.

Thank you!

davidlday avatar Jun 24 '20 11:06 davidlday