David Khourshid comments

Results 451 comments of


                                            David Khourshid

Fixed an issue that has caused `MachineConfig` parametrized with a subset of events not being accepted as part of the `MachineConfig` accepting the whole set of those events

Some failing tests (TypeScript) but otherwise LGTM

Fixed an issue that has caused `MachineConfig` parametrized with a subset of events not being accepted as part of the `MachineConfig` accepting the whole set of those events

Is this still valid? (yes doing my periodic old issue/PR revisiting)

[v5] Interpret all behaviors

~~@Andarist There are 2 tests in `@xstate/react` only failing; can you help me investigate those?~~ EDIT: resolved

[v5] Interpret all behaviors

@Andarist Some conflicts, can you help with those?

[v5] Interpret all behaviors

Re: `.start(initialState)`, I agree with deprecating it, and propose the idea that if a machine's behavior will change due to some preliminary data (such as input, restored state, or custom...

[v5] Interpret all behaviors

@Andarist This is ready for final review pending merge conflicts

[core] Add .onError() handler to service

> It would be great to define (in the docs) what's the exact purpose of `onError`. What it should do and what it can't do. The purpose of `onError` is...

[core] Add .onError() handler to service

> > The purpose of onError is to be a mechanism for the parent to subscribe to errors, whether it's error.* events or thrown errors. > > Is it supposed...

[core] Add .onError() handler to service

> @davidkpiano I noticed that [errors thrown within `.onTransition` handlers are unhandled](https://codesandbox.io/s/crazy-goldwasser-tobfn). Would this PR make it easier to catch these `Service` errors? Has the Error RFC been worked on...

[@xstate/graph][@xstate/test] Add support for `initialState`; add `testModel.getShortestPathsFrom()`

@Andarist @farskid Ping on this review?