Dave Kelsey

``` Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ ``` There doesn't appear to be a...

fabric 2.5 will be the next LTS release which will hopefully be released in dec 2022. At this time the old sdks will be marked as deprecated in favour of...

We need more documentation about each of the various benchmark packages that exist and what they deomonstrate. The most interesting one is the fabric-api package that looks to test fabric...

Need best practices for constructing GRPC clients documented or in samples

10

Using just node as a client for now I messed around with changing the parameters to GrpcClient creation to see how helpful it was when something was not done right...

As referenced here https://stackoverflow.com/questions/65993532/hyperledger-error-when-trying-to-query-the-state-database-after-installing-the-c/66100010#66100010 and raised here https://jira.hyperledger.org/browse/FABCAG-34 The minimum should be to document the limitation

Looking at the docs for getCreator you see ``` getCreator() Returns the identity object of the chaincode invocation's submitter Returns: Type ProposalCreator ``` But the type of ProposalCreator doesn't match...

I looked on https://hyperledger.github.io/fabric-chaincode-node/release-2.2/api/index.html and cannot find this class documented yet it is important for users who want to use state based endorsement

As mentioned here https://hlf.readthedocs.io/en/latest/developapps/transactioncontext.html#stub and also https://github.com/hyperledger/fabric-chaincode-go/blob/main/shim/interfaces.go The information about it only be usable in the outer most chaincode should be added

Retrieve public MSP information from channel config for fabric driver resolvers

2

For the fabric driver resolvers you might have an entry such as ``` endpoint: resolvers: - name: approver domain: org1.example.com identity: mspID: Org1MSP path: /home/dave/github-cloned/fabric-smart-client/samples/fabric/iou/testdata/fabric.default/crypto/peerOrganizations/org1.example.com/users/[email protected]/msp/signcerts/[email protected] ``` Currenly the path either...

Looking at some of the code, I have concerns that there isn't enough error checking on missing entries or incorrectly specified entries in core.yaml that could result in cryptic errors...