angular-table
angular-table copied to clipboard
davidjnelson
some fix
Wow, this is awesome, thank you! I'll take a look as soon as I get my computer back from apple. It's in the shop for a repair.
I'm still working through this. Sorry it's taking so long! I really appreciate your contribution. I added you to the contributors at the top of the http://angulartable.com site.
Thanks so much for your contribution. I love what you've done. I've decided to take angular-table in a new direction for 1.1.0, re-writing it from scratch using TDD to address many architectural issues that version 1.0.0 had which lead to bugs. I've been deeply inspired by your ideas, and will incorporate them into 1.1.0. When 1.1.0 is released, I encourage you to keep forking and submitting pull requests. As I mentioned, I've listed you as a contributor at the top of the project homepage. Thanks again!!!!
I'm looking forward for Angular Table 1.1. I really like this library.
Something come in my mind some weeks ago: Did you think about use attribute as directive not element. I mean this:
in that case maybe you can use the standard angular transclude functions, not harmned by anonymous tables [ http://www.w3.org/TR/CSS2/tables.html#anonymous-boxes]
2013/9/17 David Nelson [email protected]
Thanks so much for your contribution. I love what you've done. I've decided to take angular-table in a new direction for 1.1.0, re-writing it from scratch using TDD to address many architectural issues that version 1.0.0 had which lead to bugs. I've been deeply inspired by your ideas, and will incorporate them into 1.1.0. When 1.1.0 is released, I encourage you to keep forking and submitting pull requests. As I mentioned, I've listed you as a contributor at the top of the project homepage. Thanks again!!!!
— Reply to this email directly or view it on GitHubhttps://github.com/davidjnelson/angular-table/pull/28#issuecomment-24567206 .
Thanks Radics! :-)
Ya, what I'm doing with 1.1 is actually doing it all with divs. The primary motivation is because I'm going to do virtualization, so a table with millions of rows can be handled by adding and removing items from the dom as it's scrolled. But a nice side effect is that I don't have to deal with the tr and td not being able to be used as a root element issue, so I can use directives more as they are intended to be used.
:/ that's bad news. Exactly why i change for angular-table because it use table not divs and therefore rows are getting bigger when i have higher content. I don't know how will you implementing but I thing ng-grid use it a bad way as it has fixed row height. extjs and kendo just use table... divs (with or without css table layout) imho are not better... L
2013/9/17 David Nelson [email protected]
Thanks Radics! :-)
Ya, what I'm doing with 1.1 is actually doing it all with divs. The primary motivation is because I'm going to do virtualization, so a table with millions of rows can be handled by adding and removing items from the dom as it's scrolled. But a nice side effect is that I don't have to deal with the and not being a root element issue, so I can use directives more as they are intended to be used.
— Reply to this email directly or view it on GitHubhttps://github.com/davidjnelson/angular-table/pull/28#issuecomment-24617404 .
This is a very important insight. So with a div, let's say you make something bigger by making it be font-size: 40px or whatever. It doesn't stretch the div? I'll create a plunkr, if you want to explore it with me. I want to make sure this is the best angular grid in existence.
Plunkr: http://plnkr.co/edit/N5TxHtLn2nFdXSYcMoYI?p=preview
It seems ok. Can you edit the plunk a bit to explain why the div approach limits what you want to do? I would be super grateful. Thanks so much!!
I'm comparing big text in a div versus in a table in the plunk.
http://plnkr.co/edit/N5TxHtLn2nFdXSYcMoYI?p=preview
To me, it looks the same. I want to understand your concern though. Can you explain it in terms of the plunker?
I'll definitely make sure there is not a fixed row height, I think that would be horrible as well. Thanks so much Radics!!
if you want to implement that way the scrollbar looks like if all of the data loaded - to jump anywhere easily in the data. It's need fixed height row. This is my other problem: http://plnkr.co/edit/65PFcBCVmKGosolitcQN?p=preview it can avoid if you use: display:table-row, table-cell. but in this case why not use table semantics for a table?
2013/9/18 David Nelson [email protected]
I'm comparing big text in a div versus in a table in the plunk.
http://plnkr.co/edit/N5TxHtLn2nFdXSYcMoYI?p=preview
To me, it looks the same. I want to understand your concern though. Can you explain it in terms of the plunker?
I'll definitely make sure there is not a fixed row height, I think that would be horrible as well. Thanks so much Radics!!
— Reply to this email directly or view it on GitHubhttps://github.com/davidjnelson/angular-table/pull/28#issuecomment-24630553 .
To add to what @garaboncias was saying, the main reason I use this library is that it doesn't use div tags and absolute positioning for virtualized scrolling.
A major limitation of nggrid is that because it uses absolutely positioned divs to create it's rows, having rows of variable heights is very challenging, since the height of the row needs to be fixed in order to calculate the top offset for each row.
This limits the ability to have things like a row that expands to show more detail, since the row height is fixed.
Thanks guys. The reason I was thinking of moving away from tables was for virtualized scrolling ( removing dom elements from the top and adding to the bottom when the user scrolls down ). It's my understanding that tables don't work well for this use case. So I need to see if I can get divs to be able to auto resize like you guys need. I think both use cases ( auto resizing grid cells, and virtualized scrolling are important, and both need to work at the same time ). I'd love to hear both of your take on this. Thanks guys.
Hi Radics ( @garaboncias ),
It is taking me far too long to release version 1.1, and since you did such a great job fixing so many bugs I want to get your pull request merged as 1.0.1. When I tried using it, it didn't really seem to work. I may have done my merge incorrectly, and it's certainly my fault for not having unit tests in place.
If you feel like it, would you mind putting your proposed version up somewhere alongside the demo that I link to in the github doc ( http://angulartable.com/demo/index.html )? Then we can look at it together and work on getting the pull request merged.
Thanks so much Radics!!! Best, David
p.s. Do you prefer to be called Radics, or a different name? Thanks!
Hi David! Here is my version, i push some more little modification. One is very important: to not copy model data on angular watch . https://dl.dropboxusercontent.com/u/68171863/angular-table/index.html L
2013/10/12 David Nelson [email protected]
Hi Radics,
It is taking me far too long to release version 1.1, and since you did such a great job fixing so many bugs I want to get your pull request merged as 1.0.1. When I tried using it, it didn't really seem to work. I may have done my merge incorrectly, and it's certainly my fault for not having unit tests in place.
If you feel like it, would you mind putting your proposed version up somewhere alongside the demo that I link to in the github doc ( http://angulartable.com/demo/index.html )? Then we can look at it together and work on getting the pull request merged.
Thanks so much man!!! Best, David
— Reply to this email directly or view it on GitHubhttps://github.com/davidjnelson/angular-table/pull/28#issuecomment-26181781 .
Looks great! I must have done my merge wrong when I tested it before, sorry about that! I'm noticing a little issue when running it on my ipad 4. The cell selection highlights a cell between zero to five rows down in a darker color for a short amount of time, then highlights the correct cell shortly thereafter. It doesn't do it at on the top rows, and as you go further down the rows it highlights the wrong cell temporarily on a further down row. It seems to top out around five rows below for the flicker. Are you able to reproduce that one?
Looking at it on my macbook pro, I don't see that. It's probably the row hover color rendering weird on mobile webkit. We might want to just disable the hover on mobile - hopefully there's a media query for that, not sure.
I noticed that when I remove all 50 rows, then add 50 rows back, the column headers don't resize so that they line up.
I can't reproduce this resize bug. But i see the touch bug in simulator, it's definitely a bug. I thing something like this would be preferred ( http://stackoverflow.com/a/14594311/2190787)
Other: The live reload script in the bottom of the index.html page is make my safari waiting forever to load the page.
2013/10/13 David Nelson [email protected]
I noticed that when I remove all 50 rows, then add 50 rows back, the column headers don't resize so that they line up.
— Reply to this email directly or view it on GitHubhttps://github.com/davidjnelson/angular-table/pull/28#issuecomment-26209745 .
Hi Radics,
To reproduce it, what I did was:
- load https://dl.dropboxusercontent.com/u/68171863/angular-table/index.html in chrome latest on osx mountain lion
- click the 'remove all rows' button
- click the 'add 50 rows' button
Best, David
I also see the header columns not lining up with the other columns in safari latest and firefox latest on osx too.
Actually, the version prior to your pull request has the same issue in firefox. There's actually a bug entered for it. But now it also happens on chrome and safari, with the pull request applied.
strange, because i also use mountain lion and i have no layout issue no with chrome, ff, safari or opera.
2013/10/14 David Nelson [email protected]
Actually, the version prior to your pull request has the same issue in firefox.
— Reply to this email directly or view it on GitHubhttps://github.com/davidjnelson/angular-table/pull/28#issuecomment-26236250 .
I'm having a related issue where my angularTableTableContainer is set to height: 0px since I'm starting with an empty table. When I load my data via AJAX the height does not update.
Would this commit be the solution? https://github.com/garaboncias/angular-table/commit/2b5a32a07fd050dacc38bb68bf3c036f4b8fbd1b
<div class="angularTableTableContainer" style="height: 0px;">
@garaboncias I can also reproduce the shifted headers error on OSX Mavericks Chrome Version 32.0.1700.107
