David Goss

Results 186 comments of David Goss

Thanks @notaphplover, that makes sense now. I'll follow up here soon.

Sorry for the late reply @notaphplover. I'm keen to support this but also to maintain the existing exports pattern as I think it's ergonomic for most users. A bit similar...

and/or, your default export could be a function that returns (a promise for) a map of profiles?

Two thoughts: - I'd say "electron" is an implementation detail and thus not a great name. What about `--interactive` or `--ui` or something? - We might consider making this an...

Peer dependencies I’m not sure about - since npm 7 by default it throws if peer dependencies are missing. There’s no way of specifying “optional peers” unfortunately. But we could...

@BlueMona thanks for getting this going, and great idea to start with the scenario. I think my only suggestion would be for the stuff that we set in `BeforeAll` to...

Thanks for the update @BlueMona, this is looking good. To your points: > is object an ok type for testRunContext? It's kinda the same need as `worldParameters`, which we type...

@mattwynne yeah that's basically what I was suggesting, although we'd want a [deep clone](https://www.npmjs.com/package/lodash.clonedeep) since doing a spread just gives you a shallow clone.

This is shaping up nicely. @mattwynne for the world I think we should use the existing structures i.e. add `testRunContext` to the constructor object for the built in world and...

Also there are some tests specifically around types that you might want to look at and/or extend https://github.com/cucumber/cucumber-js/blob/main/test-d/world.ts