iframe-resizer icon indicating copy to clipboard operation
iframe-resizer copied to clipboard

Add addEventListener() and removeEventListener() methods

Open gruns opened this issue 5 years ago • 5 comments

Currently event handlers can only be setup at initialization time in the constructor's options parameter.

Instead, iFrameResizer should implement the standard EventTarget interface

  • https://developer.mozilla.org/en-US/docs/Web/API/EventTarget

with addEventListener(), removeEventListener(), and dispatchEvent() so 1) iFrameResizer follows the standard JS events API and 2) event handling can change dynamically.

gruns avatar May 20 '19 05:05 gruns

Do you want to make a PR?

davidjbradshaw avatar Jun 10 '19 09:06 davidjbradshaw

Do you want to make a PR?

I'd love to, but I am starved for time right now. I won't be able to take a stab at this for, at minimum, a few weeks.

To anyone with providential inclination: feel free to take a crack at this.

gruns avatar Jun 28 '19 23:06 gruns

I am on holiday for the next month, so no rush

davidjbradshaw avatar Jul 02 '19 12:07 davidjbradshaw

Roadmapped for v5.1

davidjbradshaw avatar Feb 13 '24 15:02 davidjbradshaw