iframe-resizer icon indicating copy to clipboard operation
iframe-resizer copied to clipboard

SyntaxError: Failed to execute 'querySelectorAll' on 'Document': '[data-iframe-overflowed]:not([data-iframe-ignore]):not([data-iframe-ignore] *)' is not a valid selector.

Open wouterds opened this issue 9 months ago • 4 comments

Describe the bug There seems to be an issue with the querySelectorAll invocation in the @iframe-resizer/child package. We have a couple of thousand errors regarding this in Sentry. From what I can see it happens on Chrome, Chrome Mobile, Safari, Android, Windows, macOS, ... there's no concise pattern of browser & OS.

To Reproduce I'm not sure how to reproduce it, I just see it happens a lot in our error logs.

Expected behavior Ideally it doesn't happen and is handled in safe manner and/or has a fallback.

Additional context Would you be able to have a look at this? I have included our Sentry error if that helps. → https://tallyforms.sentry.io/share/issue/fc1097ac60a94dbd8a5c607598df43dc

Image

Edit: Chad its 2 cents:

Image

wouterds avatar May 26 '25 10:05 wouterds

Good catch, weird that you can only catch it randomly. I test across all the main browsers and have never seen this come up. Will have to build a more detailed test case to see if I can trigger it.

I will take ChatGPT’s advice on how to fix it.

davidjbradshaw avatar May 26 '25 11:05 davidjbradshaw

I've not been able to reproduce this issue, but hopefully 4.5.7-beta.1 should fix it.

I would be grateful if you could give it a try and let me know.

Dave.

davidjbradshaw avatar Jun 03 '25 12:06 davidjbradshaw

Hi Dave,

I think the 4.5.7-beta.1 fixes it, we typically see about 10 events an hour and I haven't seen any over the last 4 hours since we deployed.

Thanks for looking into this so promptly!

wouterds avatar Jun 04 '25 12:06 wouterds

Thanks for letting me know, I think it will be another week before I wrap up the other bits in the next release, so lets keep this ticket open a few more days, just in case it pops up again.

davidjbradshaw avatar Jun 04 '25 12:06 davidjbradshaw