react-spinners icon indicating copy to clipboard operation
react-spinners copied to clipboard

HashLoader color is taken from the last HashLoader component

Open Legend999 opened this issue 1 year ago • 1 comments

Package Version 0.13.8

Describe the bug HashLoader color is taken from the last HashLoader component. If we have 2 HashLoaders with different assigned colors, they will have the color of the last one.

In the following case, both loaders will be green:

<HashLoader color="red" />
<HashLoader color="green" />

To Reproduce https://codesandbox.io/p/devbox/lucid-tom-vql768-forked-zcnzjh

Expected behavior The first loader should be red and the second one should be green.

Screenshots image

Legend999 avatar Mar 16 '24 09:03 Legend999

had to revert this change since it breaks SSR + jest snapshots. Will need to think about how to do this better. maybe including the color as part of the animation name make sense, something deterministic

davidhu2000 avatar Jun 28 '24 16:06 davidhu2000