David Horstmann
David Horstmann
@gstrauss apologies for the delay. If you add this change, I'll do the second review and @AndrzejKurek can re-review.
Ah apologies I should have explained. Earlier I self-requested a review and then removed Gilles as a reviewer to mark the fact that myself and Andrzej were planning to review...
@gstrauss I'm happy for you to make this change and we'll be able to re-review promptly since it's a small change. A quick note on adding changes: we usually prefer...
(CI failure is unrelated to this PR)
This link has since been updated, closing.
This is duplicated by #6629. Since that PR has passed CI, I'll review it in preference to this PR.
> I am also not sure whether this needs a 3.6 backport. The ABI checker hasn't failed here, so perhaps it does. Yes, I think this needs a 3.6 backport,...
Ah thanks for spotting that! I think you are right, the original PR was created pre-release, so `generate_psa_wrappers.py` was not included. I'll rebase the original (and relevant framework PR) and...
Issue (1) was fixed by #7849, which ensures that the DN contains at least 1 AttributeType=AttributeValue pair.
@daverodgman Apologies, I didn't get round to it. I'm running them now though