David Hodge

Results 51 comments of David Hodge

A function graph is used to show how x relates to y. So I think regardless of the internals that it should have a title

Could `GeomDensity2d` default to `contour = TRUE` to match `geom_density_2d` defaults? Likewise, `GeomDensity2dFilled`

I'm not sure how to do this, sorry @teunbrand. I'm not familiar with how ggproto works

+1 for this. The consistency proposed here would really help. Don't suppose this could be in 3.5.1?

I also find the prefix `update` a bit long, which makes `update_geom_defaults()` hard to read. Perhaps `add_*` could be used here instead of `update_*`? So: `add_geom_defaults()` `add_theme()` Instead of: `update_geom_defaults()`...

Oh okay, so have `set_geom_defaults` instead of `update_geom_defaults`? I think that'd be way better. I like brevity/symmetry too

Assume this isn't planned to be implemented for 3.5.1 @teunbrand ?

Is it possible that `GeomSmooth` could default to `se = TRUE` to match what we see in `geom_smooth`?

This seems to have somehow got fixed, even though no code has been added to main?? ``` r library(tidyverse) economics |> filter(between(date, ymd("1990-01-01"), ymd("1990-03-01"))) |> ggplot() + geom_line(aes(date, unemploy)) +...

Pretty weird, but great :) Closed the PR as well Maybe it was grid or vctrs, or something else..