David Hewitt comments

Results 1495 comments of


                                            David Hewitt

PydanticSerializationError missing validation error field name

Seems like a reasonable request to me, I think this just needs some refactoring. cc @sydney-runkle

Failed to install pydantic-core from sources

Yep this has now been fixed in `maturin`.

Fail-fast feature

Seems fine to me. I'm less sure about the `FailNow` structure; it might be better to instead pass `fail_fast` in the `info` and then let custom validators decide when to...

SIGSEGV Linux arm64, python3.13-nogil

Nogil is expected not to work yet, see https://github.com/PyO3/pyo3/issues/4265 - which I hope to ramp up development work on soon

SIGSEGV Linux arm64, python3.13-nogil

Fixed as per #1555

Set up criterion and impl `std::error::Error` for error types

Looks like this introduces a dependency on `half` that is not MSRV compatible. It might be possible to tune things to make that not the case.

upgrade to smallvec 2 to fix invariant lifetimes

Would be made irrelevant by #184

Simplify lightweight clones, including into closures and async blocks

Thank you for working on this RFC! PyO3 necessarily makes heavy use of Python reference counting so users working on Rust + Python projects may benefit significantly from making this...

`AttributeError: 'EqValue' object has no attribute '_changes'` when using `pytest-run-parallel`

Thanks, looks like `--inline-snapshot=disable` makes the whole test suite green. If it's possible to make `inline-snapshot` thread-safe, I'm sure that would be useful for pushing free-threaded testing across the ecosystem.

Consistent validation with complex number to float type coercion

It looks like this got stuck for the last ~9 months following from https://github.com/pydantic/pydantic-core/pull/1574#discussion_r1880085282. Thank you for the PR, I will close it. If someone still wants the lax coercion...