David Hewitt comments

Results 1495 comments of


                                            David Hewitt

`Clone` (or alternative) on `GILOnceCell`

For freethreaded `GILOnceCell`, I'd welcome any opinions on #4512 and #4513

Add "dummy" schema which, if present, makes validation/serialization always fail

I would be tempted to call this `never_schema()`, inspired by `typing.Never`.

Add "dummy" schema which, if present, makes validation/serialization always fail

I guess also would resolve https://github.com/pydantic/pydantic/issues/9731 at the same time.

Validate bytes based on ser_json_bytes

Thanks for the PR! I fully support the use case and think this makes sense. That said, I worry about silently breaking user code by changing the meaning of the...

Validate bytes based on ser_json_bytes

Having discussed with @sydney-runkle and @samuelcolvin, I think we would prefer to go with a new `val_json_bytes` option so that users who do have a use-case where they don't want...

Fix `exclude_defaults` when value's `eq` method raises an exception.

We merged #1535 which adds the `exclude_if` function, so I think we can close this given the more general solution now exists. Thanks for the PR and the discussion!

Improving ergonomics of getting slices from a PyBuffer

I worry that slicing into Python-mutable memory like this risks UB due to optimizations that rustc might do due to the assumption of immutability. I think in practice this UB...

Error at compile-time when a non-subclassable class is being subclassed

Overall this looks good to me, however there seem to be some feature combinations which aren't satisfied. I'd suggest running `nox -s check-feature-powerset` to help identify the broken cases and...

Error at compile-time when a non-subclassable class is being subclassed

Pretty sure the coverage is due to other changes reducing coverage on `main` compared to the merge base on this PR. I think it can be fixed by #4472. Let's...

Error at compile-time when a non-subclassable class is being subclassed

I think the `test-debug` failure is another manifestation of https://github.com/PyO3/pyo3/pull/4185#issuecomment-2113722396 🤔