RealTimeClockDS1307 icon indicating copy to clipboard operation
RealTimeClockDS1307 copied to clipboard

Won't compile or upload on win10,ide1.8.0 or earlier, error messages below

Open grtbluyonder opened this issue 8 years ago • 2 comments

C:\Users\Allan\Documents\Arduino\libraries\RealTimeClockDS1307\RealTimeClockDS1307.cpp:168:25: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]

_reg7_sqw = _reg7_sqw & 0x80 | 0x10 | frequency;

                     ^

C:\Users\Allan\Documents\Arduino\libraries\RealTimeClockDS1307\RealTimeClockDS1307.cpp: In member function 'void RealTimeClockDS1307::sqwDisable(boolean)':

C:\Users\Allan\Documents\Arduino\libraries\RealTimeClockDS1307\RealTimeClockDS1307.cpp:176:25: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]

_reg7_sqw = _reg7_sqw & ~0x90 | (outputLevel << 7);

                     ^

C:\Users\Allan\Documents\Arduino\libraries\RealTimeClockDS1307\RealTimeClockDS1307.cpp: In member function 'void RealTimeClockDS1307::setAM()':

C:\Users\Allan\Documents\Arduino\libraries\RealTimeClockDS1307\RealTimeClockDS1307.cpp:350:27: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]

_reg2_hour = _reg2_hour & ~0x20 | 0x40;

grtbluyonder avatar Jan 01 '17 19:01 grtbluyonder

Allan, thanks. I have updated the Readme.me to encourage you to look elsewhere for up-to-date code. I have not needed this since a one-off project several years ago and didn't know how to accept other peoples' helpful contributions so they quite wisely forked the code and didn't look back. You will find better elsewhere.

davidhbrown avatar Jan 02 '17 04:01 davidhbrown

Thanks David, alas there are so many RTC libs to select from, the search begins......

On Sun, Jan 1, 2017 at 11:26 PM, David Brown [email protected] wrote:

Allan, thanks. I have updated the Readme.me to encourage you to look elsewhere for up-to-date code. I have not needed this since a one-off project several years ago and didn't know how to accept other peoples' helpful contributions so they quite wisely forked the code and didn't look back. You will find better elsewhere.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/davidhbrown/RealTimeClockDS1307/issues/5#issuecomment-269933498, or mute the thread https://github.com/notifications/unsubscribe-auth/AXtsG6iBSHMwacCXdUFFy8649X04caRFks5rOHxkgaJpZM4LYwpj .

grtbluyonder avatar Jan 02 '17 15:01 grtbluyonder