python-fmrest
python-fmrest copied to clipboard
Add super for mro
Added calls in object init() methods to super() to support python's MRO. Addresses Issue #22.
Thanks for the PR. A couple of remarks:
- The added
super()
inserver.py
currently uses tabs as indentation, leading to a TabError exception and breaking the code - We could skip the argument to
super()
, asself
should implicitly be passed (i.e. for examplesuper()
vssuper(Server, self)
) - I would prefer to pass the surplus args only via kwargs to avoid confusion and make it more explicit when using multiple inheritance. What do you think? I'm currently also getting a mypy error for the super calls complaining about the call to
object
's__init__
with args, but I assume this should be fine as surplus args should already be consumed before the last__init__
call.